Gradual typing #1217

akaihola · 2024-08-29T18:16:13Z

Here's another stab at adding typing since #639 was closed.

I acknowledge that Paul has expressed that he isn't currently planning to add type hints, and that reviewing type hints would be a burden.

However, I believe this extremely minimal Mypy configuration and a minimal set of changes not only make Mypy pass, but also enable to use it to check some types, and allow development to continue without requiring full type hints everywhere.

Mypy takes over the burden of reviewing type annotations from humans.

Most notably, functions with no type hints are not checked by Mypy at all with this configuration. This allows adding type hints just only to select sections of the code base. It is still of course possible to gradually add typing overall and increase Mypy's strictness if desired.

See Using mypy with an existing codebase for more information.

ruancomelli · 2024-09-16T12:10:33Z

aider/coders/base_prompts.py

@@ -35,7 +38,7 @@ class CoderPrompts:
        " stop and wait for your approval."
    )

-    repo_content_prefix = """Here are summaries of some files present in my git repository.
+    repo_content_prefix: str | None = """Here are summaries of some files present in my git repository.


The type union syntax X | Y is only available in Python 3.10, but Aider still supports Python 3.9.
Instead, this should be

Suggested change

repo_content_prefix: str | None = """Here are summaries of some files present in my git repository.

repo_content_prefix: typing.Optional[str] = """Here are summaries of some files present in my git repository.

On line 1 of this file, I've added

from __future__ import annotations

which makes sure X | Y is supported on Python 3.9.

Need to put that in the tests too it looks like:

TypeError: unsupported operand type(s) for |: 'type' and 'NoneType'

nedtwigg · 2024-09-18T17:27:10Z

I would think that typing an untyped python codebase is exactly the kind of thing that Aider itself would be great at. Typing the edges is trivial, that leads to type errors, fix those, that leads to new type errors, fix those, etc.

I also think if it's worth adding type annotations at all, then it's worth bumping to a Python version that supports the latest / greatest versions of them. Aider seems like more of an end-user thing than infrastructure library, seems okay for it to be more aggressive in bumping requirements than a typical library.

Faolain · 2024-09-22T05:39:06Z

Amazing work as this will make aider improving itself even better (from experience llms do quite well with typed code)

CLAassistant · 2024-10-16T07:47:21Z

All committers have signed the CLA.

akaihola · 2024-12-29T21:20:59Z

I rebased on main and fixed all typing errors which had appeared meanwhile. Also added a requirements file for running Mypy. It includes Mypy itself and some type stub packages. The workflow now uses this requirements file as well as other requirements files needed for type checking.

ryanpeach · 2025-01-22T16:22:38Z

Have you considered pyright instead? Pyright is fast enough to work in your vscode and neovim live, and can go in your pre-commit.

Also we should put typing into the github actions.

Personally I think typing will make aider better both in scripting mode (making it more understandable to devs, less likely for bugs) and for self-modification via aider (it will improve the linting loop, and will give more informative repo maps).

I'd definitely love to see a blog post about the accuracy of aider edits under properly typed vs untyped code generation.

ryanpeach

Very minimal IMO. I like it (though I have no authority)

ryanpeach · 2025-01-22T17:05:41Z

.github/workflows/lint.yml

+      run: |
+        python -m pip install --upgrade pip
+        pip install '.[browser,dev,playwright,mypy]'
+


add flake8 and black checks as they are in the pre-commit

Better to just add https://github.com/pre-commit/action

ryanpeach

A few more lint comments

ryanpeach · 2025-01-22T17:47:46Z

.github/workflows/lint.yml

+name: Linting
+
+on:
+  push:


Not sure why we need this on push, just PR right?

ryanpeach · 2025-01-22T17:48:04Z

.github/workflows/lint.yml

+    - name: Set up Python 3.12
+      uses: actions/setup-python@v5
+      with:
+        python-version: "3.12"


Use a matrix like in the other workflows

ryanpeach · 2025-01-22T18:36:19Z

ERROR: Cannot install None, aider-chat and aider-chat[browser,dev,mypy,playwright]==0.1.dev1+g1aa8de2 because these package versions have conflicting dependencies.

The conflict is caused by:
    aider-chat 0.1.dev1+g1aa8de2 depends on attrs==24.3.0
    aiohttp 3.11.11 depends on attrs>=17.3.0
    jsonschema 4.23.0 depends on attrs>=22.2.0
    referencing 0.36.0 depends on attrs>=22.2.0
    aider-chat[browser,dev,mypy,playwright] 0.1.dev1+g1aa8de2 depends on attrs==24.3.0
    aider-chat[browser,dev,mypy,playwright] 0.1.dev1+g1aa8de2 depends on attrs==24.3.0; extra == "browser"
    aider-chat[browser,dev,mypy,playwright] 0.1.dev1+g1aa8de2 depends on attrs==24.2.0; extra == "mypy"

To fix this you could try to:
1. loosen the range of package versions you've specified
2. remove package versions to allow pip to attempt to solve the dependency conflict

https://github.com/OnScale/aider-stateless/actions/runs/12914071198/job/36012781606?pr=7

- skip some directories - skip 3rd party packages without typing or type stubs - allow untyped globals and class attributes - don't check untyped functions and methods

Also avoid building a list and overwriting it with a tuple.

akaihola mentioned this pull request Aug 29, 2024

Clean up types and drop an unused variable #1216

Merged

4 tasks

akaihola force-pushed the gradual-typing branch from 32341d4 to 7055239 Compare August 29, 2024 20:20

ruancomelli reviewed Sep 16, 2024

View reviewed changes

akaihola force-pushed the gradual-typing branch from 7055239 to 8058187 Compare September 17, 2024 13:10

akaihola force-pushed the gradual-typing branch 4 times, most recently from 0f49a3d to 6416497 Compare October 5, 2024 19:15

akaihola force-pushed the gradual-typing branch 2 times, most recently from 1a50afe to 77438bb Compare December 29, 2024 20:54

ryanpeach approved these changes Jan 22, 2025

View reviewed changes

ryanpeach mentioned this pull request Jan 22, 2025

Mypy #2966

Closed

ryanpeach suggested changes Jan 22, 2025

View reviewed changes

akaihola added 11 commits January 31, 2025 21:03

chore: configure Mypy

d6ae467

- skip some directories - skip 3rd party packages without typing or type stubs - allow untyped globals and class attributes - don't check untyped functions and methods

fix: __all__ must contain strings, not objects

ea33df3

fix: | None type for attrs overridden as None

4ed26cb

fix: avoid reassignment to different type

5ff40a6

fix: namedtuple syntax Mypy is happy with

e19b889

chore: add requirements for running mypy

60c480d

chore: add GitHub workflow to run Mypy

1b7fcb3

fix: work around typing of conditional imports

e060fc1

Also avoid building a list and overwriting it with a tuple.

fix: correct description type in ExInfo

1e9ee36

fix: correct return type for check_for_urls()

fd9d5cf

fix: use CoderPrompts base class as type for AskCoder.gpt_prompts

c568cb0

akaihola force-pushed the gradual-typing branch from 94c963c to c568cb0 Compare January 31, 2025 19:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Gradual typing #1217

Gradual typing #1217

akaihola commented Aug 29, 2024 •

edited

Loading

ruancomelli Sep 16, 2024

akaihola Sep 17, 2024

ryanpeach Jan 22, 2025

nedtwigg commented Sep 18, 2024

Faolain commented Sep 22, 2024

CLAassistant commented Oct 16, 2024 •

edited

Loading

akaihola commented Dec 29, 2024

ryanpeach commented Jan 22, 2025 •

edited

Loading

ryanpeach left a comment

ryanpeach Jan 22, 2025

ryanpeach Jan 22, 2025

ryanpeach left a comment

ryanpeach Jan 22, 2025 •

edited

Loading

ryanpeach Jan 22, 2025

ryanpeach commented Jan 22, 2025

	repo_content_prefix: str \| None = """Here are summaries of some files present in my git repository.
	repo_content_prefix: typing.Optional[str] = """Here are summaries of some files present in my git repository.

Gradual typing #1217

Are you sure you want to change the base?

Gradual typing #1217

Conversation

akaihola commented Aug 29, 2024 • edited Loading

ruancomelli Sep 16, 2024

Choose a reason for hiding this comment

akaihola Sep 17, 2024

Choose a reason for hiding this comment

ryanpeach Jan 22, 2025

Choose a reason for hiding this comment

nedtwigg commented Sep 18, 2024

Faolain commented Sep 22, 2024

CLAassistant commented Oct 16, 2024 • edited Loading

akaihola commented Dec 29, 2024

ryanpeach commented Jan 22, 2025 • edited Loading

ryanpeach left a comment

Choose a reason for hiding this comment

ryanpeach Jan 22, 2025

Choose a reason for hiding this comment

ryanpeach Jan 22, 2025

Choose a reason for hiding this comment

ryanpeach left a comment

Choose a reason for hiding this comment

ryanpeach Jan 22, 2025 • edited Loading

Choose a reason for hiding this comment

ryanpeach Jan 22, 2025

Choose a reason for hiding this comment

ryanpeach commented Jan 22, 2025

akaihola commented Aug 29, 2024 •

edited

Loading

CLAassistant commented Oct 16, 2024 •

edited

Loading

ryanpeach commented Jan 22, 2025 •

edited

Loading

ryanpeach Jan 22, 2025 •

edited

Loading